Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mount angles message for communications with ardupilotmega. #1606

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Add Mount angles message for communications with ardupilotmega. #1606

merged 6 commits into from
Aug 30, 2021

Conversation

BV-OpenSource
Copy link
Contributor

No description provided.

Jaeyoung-Lim
Jaeyoung-Lim reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason that this cannot be included in the mount_control plugin?

@BV-OpenSource
Copy link
Contributor Author

Is there a specific reason that this cannot be included in the mount_control plugin?

Not at all. Simply didn't want to mix functionalities since mount_control plugin already has a callback to return position status but mavlink message was different.

vooon
vooon requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be part of mount_control. Why not?

mavros_msgs/msg/MountStatus.msg Outdated Show resolved Hide resolved
mavros_extras/src/plugins/mount_status.cpp Outdated Show resolved Hide resolved
vooon
vooon approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vooon vooon merged commit ccda446 into mavlink:master Aug 30, 2021
@vooon vooon added this to the Release 1.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim requested changes

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
enhancement extras
Projects
None yet
Milestone
Release 1.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BV-OpenSource @vooon @Jaeyoung-Lim @amilcarlucas