Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmavconn: Feature to select hardware flow control #649

Closed
vooon opened this issue Jan 28, 2017 · 3 comments
Closed

libmavconn: Feature to select hardware flow control #649

vooon opened this issue Jan 28, 2017 · 3 comments
Labels
API change enhancement feature request
Milestone
Version 0.19

Comments

@vooon
Copy link
Member

vooon commented Jan 28, 2017 •
edited
Loading

@sharvashish asked to support hw flow control (RTS/CTS lines).
That should be easy, but require API change (flag) and new URL proto (maybe serial-hf://?).
@vooon vooon added this to the Version 0.19 milestone Jan 28, 2017
@sharvashish
Copy link

Hi guys,
I tried changing serial_dev.set_option(serial_port_base::flow_control(serial_port_base::flow_control::none));
to
serial_dev.set_option(serial_port_base::flow_control(serial_port_base::flow_control::hardware));
in libmavconn/src/serial.cpp.

I could successfully compile the code as well. But I got a runtime error. I would post the error, next time I execute the same code.

vooon added a commit that referenced this issue Feb 24, 2017
@vooon
libmavconn #649: Add serial-hwfc:// proto (serial + hardware flow con…
e19ac5b 
…trol)

Note: not all platforms support setting
  Boost::asio::serial_port_base::flow_control::hardware option.
@vooon
Copy link
Member Author

vooon commented Feb 24, 2017

New proto was added, but i don't have tty device with support.
Or perhaps Boost.ASIO Linux backed do not support that option? Anyway it is hidden and do not require any changes of libmavconn code.

@vooon vooon closed this as completed Feb 24, 2017
@mhkabir
Copy link
Member

mhkabir commented Mar 8, 2018

This was broken since implementation due to Boost bugs. Fix is here: #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API change enhancement feature request
Projects
None yet
Milestone
Version 0.19
Development

No branches or pull requests
3 participants
@vooon @mhkabir @sharvashish