Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavsys: mode: add solutions for setting AUTO.MISSION and AUTO.LOITER modes #814

Merged
merged 5 commits into from
Sep 20, 2017

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Sep 18, 2017

Also the enums are updated - can push this to another PR if needed.

base_mode = 0
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like rebase error ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fixed @khancyr. thanks

@TSC21
Copy link
Member Author

TSC21 commented Sep 18, 2017

Looks like we don't need to unset the datalink failsafe. For PX4, the heartbeat type published by sys_status, for now, needs to be of type MAV_TYPE_GCS so to be accepted and published on the telemetry_status uORB msg and that way set the datalink stream. IOT it be accepted also with MAV_TYPE_ONBOARD_CONTROLLER, I will purpose a patch to the Firmware.
And that is not all: https://github.com/PX4/Firmware/blob/master/src/modules/mavlink/mavlink_receiver.cpp#L1718 - the 1st condition is that msg->sysid != mavlink_system.sysid, so we cannot have system_id == tgt_system_id. And that's why I'm adding that option by default to the launch files.

@TSC21
Copy link
Member Author

TSC21 commented Sep 18, 2017

@shakthi-prashanth-m for your interest.

@TSC21
Copy link
Member Author

TSC21 commented Sep 18, 2017

@khancyr in Ardupilot is there any special case like this? Do you treat the hearbeat differently according to the MAV_TYPE?

@TSC21 TSC21 changed the title mavsys: mode: be verbose on setting AUTO modes mavsys: mode: add solutions for setting AUTO.MISSION and AUTO.LOITER modes Sep 18, 2017
@TSC21 TSC21 mentioned this pull request Sep 19, 2017
@vooon
Copy link
Member

vooon commented Sep 19, 2017

Mavros sysid may be set via url, addition to launch is not required.
But for me that check looks weird, because OBC is part of same Unmanned System as FCU.

So FCU should understand when (hb.sysid == my.sysid && hb.type == OBC) - we have link with our OBC.

@TSC21
Copy link
Member Author

TSC21 commented Sep 19, 2017

It can't. If the sysid is the same, it will start listening to its own hb. What may make sense is to make a check to the component id

@vooon vooon merged commit 5c6da7a into mavlink:master Sep 20, 2017
@vooon vooon added this to the Version 0.22 milestone Sep 20, 2017
@TSC21 TSC21 deleted the fix_set_mode branch September 30, 2017 11:47
@TSC21 TSC21 mentioned this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants