Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obstacle_distance: report LaserScan.ranges (meters) as OBSTACLE_DISTANCE.ranges (centimeters) #950

Closed
vooon opened this issue Feb 19, 2018 · 7 comments
Closed

obstacle_distance: report LaserScan.ranges (meters) as OBSTACLE_DISTANCE.ranges (centimeters) #950

vooon opened this issue Feb 19, 2018 · 7 comments
Labels
bug extras plugin
Milestone
Version 0.24

Comments

@vooon
Copy link
Member

vooon commented Feb 19, 2018

With #949 i found bug in message filler. It should convert meters to centimeters and then fill message.
@vooon vooon added this to the Version 0.24 milestone Feb 19, 2018
@TSC21
Copy link
Member

TSC21 commented Feb 19, 2018

Ok I see the bug now. @mrivi will update this soon.

@vooon
Copy link
Member Author

vooon commented Feb 19, 2018

No, that bug is mine :) Just i'm trying to imagine best solution. And i'm recommend that std::copy() code.

@TSC21
Copy link
Member

TSC21 commented Feb 19, 2018 •
edited
Loading

If you divide every value by 100 and round it inside std::copy() it should work.

@vooon
Copy link
Member Author

vooon commented Feb 19, 2018

1 m == 100 cm. Div 1e2.

@TSC21
Copy link
Member

TSC21 commented Feb 19, 2018 •
edited
Loading

I know. Forgot a zero :)

@vooon vooon closed this as completed in bea3165 Feb 19, 2018
@vooon
Copy link
Member Author

vooon commented Feb 19, 2018

Hehe, we completely screwed up on conversions :D
We should multiply by 100, not divide to get m->cm. Fixed.

@TSC21
Copy link
Member

TSC21 commented Feb 19, 2018

Ahahah nevermind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug extras plugin
Projects
None yet
Milestone
Version 0.24
Development

No branches or pull requests
2 participants
@vooon @TSC21