Add support for time synchronisation with FCU #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public: | ||
| SystemTimePlugin(): | ||
| uas(nullptr) | ||
| { |
There was a problem hiding this comment.
Don't put init code to constructor, must be in initialize(). How it might build?..
|
You forget add it to mavros/CMakeLists.txt (look list of plugin sources) and to |
|
Add: #include <sensor_msgs/TimeReference.h> |
|
@vooon Cannot fix last problem. Great if you could look into it. Leave me a comment, I'll follow up tomorrow. |
|
At line 132: you trying to divide message smart pointer (that don't implement |
|
Also i think that ros::Duration is preffered type for offset value (and for message, because time_offset can not be used as TimeReference). |
|
All done and implemented |
vooon
added a commit
that referenced
this pull request
Oct 7, 2014
Add support for time synchronisation with FCU.
|
Looks good. Merged. |
|
@vooon Thanks. APM compatibility should be OK, but please check if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timesync support. I've finished FCU implementation, but needs testing and hotfix if needed.
@vooon Please go through this, and let me know.
To use the offset anywhere else, simply subscribe to the mavros/time_offset topic and add this offset to time_boot_ms of incoming mavlink messages.
Kabir