Extras: add ardupilot rangefinder plugin #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSC21
requested changes
Jul 2, 2017
There was a problem hiding this comment.
@khancyr I don't think that adding a new plugin would be the best choice. Adding support to this msg would be better on distance_sensor plugin (the plugin name doesn't have to be directly related to its message). Besides, as you said, this would be deprecated.
vooon
approved these changes
Jul 2, 2017
|
I don't like the approach msg_type<->plugin. I think it's better purpose<->plugin, but anyway it is your call. Besides, this plugin will only allow receiving msg, no sending as |
|
@TSC21 I agree I could have put it in distance_sensor file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add ardupilot rangefinder message support. It will be deprecated with next version that support DISTANCE_SENSOR msg