Heartbeat message in the MAVLink Message Inspector doesn't display frequency

[Susurrus]

this message always appears as having a 0Hz frequency, both with the demo MAVLink file as well as with my own code that is transmitting at 1Hz and being recognized by QGC.

[Susurrus]

So looks like the problem is that messages aren't being updated properly in the MAVLink Inspector widget. If you add the line qDebug() << QString("%1:%2:%3").arg(messageInfo[msg->msgid].name).arg(messagesHz.value(msg->msgid, 0)).arg(i); to line 101 in QGCMAVLinkInspector.cc and recompile you'll see what's happening. The interface isn't properly tracking when new messages are received and so all messages map to 0 (which is the ID of the heartbeat message) when they haven't been received and so every message that hasn't been received updates the heartbeat message in this widget. This is also why even when no communications line is configured that the heartbeat message still shows up with a 0Hz frequency.

I'm uncertain of the right way to correct this issue given the existing code. Obviously there needs to be a way to only track which messages have actually be received and only update those ones. I would imagine putting received messages into a queue and pulling from that on every update would be the best way instead of polling over all message types.

[Susurrus]

Fixed in 2a42532