Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable serial ports #6905

Open
dagar opened this issue Oct 1, 2018 · 7 comments
Open

Configurable serial ports #6905

dagar opened this issue Oct 1, 2018 · 7 comments

Comments

@dagar
Copy link
Member

dagar commented Oct 1, 2018

In PX4 (PX4/PX4-Autopilot#10337) we have different modules and drivers that can be configured to use serial ports. As a result it's currently possible to have a conflict configured via parameters.

On the QGC side I'd like to add a mechanism to configure the usage per port, where QGC handles the deconfliction.

PX4

For example in PX4 we have the following parameters to configure the ports used by different mavlink instances or different GPS. Each parameter has the same drop down list of serial ports.

  • MAV_1_CONFIG
    • telem 1
    • telem 2
    • telem 3
    • gps 1
    • gps 2
  • MAV_2_CONFIG
    • telem 1
    • telem 2
    • telem 3
    • gps 1
    • gps 2
  • MAV_3_CONFIG
    • telem 1
    • telem 2
    • telem 3
    • gps 1
    • gps 2
  • GPS_1_CONFIG
    • telem 1
    • telem 2
    • telem 3
    • gps 1
    • gps 2
  • GPS_2_CONFIG
    • telem 1
    • telem 2
    • telem 3
    • gps 1
    • gps 2
      ...

QGC

On the QGC side I'd like to invert the configuration and prevent conflicts. Each serial port should only appear in a single parameter.

  • telem 1
    • Mavlink 1
    • Mavlink 2
    • Mavlink 3
    • GPS 1
    • GPS 2
  • telem 2
    • Mavlink 1
    • Mavlink 2
    • Mavlink 3
    • GPS 1
    • GPS 2
  • telem 3
    • Mavlink 1
    • Mavlink 2
    • Mavlink 3
    • GPS 1
    • GPS 2
  • gps 1
    • Mavlink 1
    • Mavlink 2
    • Mavlink 3
    • GPS 1
    • GPS 2
  • gps 2
    • Mavlink 1
    • Mavlink 2
    • Mavlink 3
    • GPS 1
    • GPS 2
@hamishwillee
Copy link
Contributor

Just FMI, but would this be the only tuning page for those parameters, or would people still be able to see the underlying MAV_3_CONFIG, MAV_2_CONFIG etc?

  • If so, then what should the proposed inverted tuning page do if these are manually set with a conflict?
  • if not, how would the docs work, since these parameters are defined in our docs but would not be visible to users.

@DonLakeFlyer DonLakeFlyer added this to the Release v3.5 milestone Oct 5, 2018
@DonLakeFlyer DonLakeFlyer removed this from the Release v3.5 milestone Jan 19, 2019
@jafrado
Copy link

jafrado commented Feb 18, 2019

Would be great to have this ...
As it stands, it's documented like this, but no way to configure com ports now:
https://docs.px4.io/en/peripherals/serial_configuration.html
https://docs.px4.io/en/peripherals/mavlink_peripherals.html

@hamishwillee
Copy link
Contributor

As it stands, it's documented like this, but no way to configure com ports now:

@jafrado What do you mean - those documents show exactly how to configure them. It just isn't very intuitive.

All this issue asks is to be able to choose the associated service running on particular port (rather than starting selecting the port used by each service.)

@jafrado
Copy link

jafrado commented Feb 18, 2019

Doesn't work with 1.8.2 and v3.5, tried today. As it stands I added mavlink commands to my extras.txt

@hamishwillee
Copy link
Contributor

@jafrado For 1.8.2 you would use SYS_COMPANION for this. In 1.9 and later you use the docs above. For a bit of guidance you can see the PR for the change here: https://github.com/PX4/px4_user_guide/pull/352/files

@dagar Can we run out versions for PX4 User Guide too so I can point to correct docs for this stuff?

@jafrado
Copy link

jafrado commented Feb 18, 2019

Got it, thanks.

@DronecodeBot
Copy link

This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/confusion-on-definition-of-telem-1-telem-2-etc/33424/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants