Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.2: Update sdl libraries to work with latest xbox bluetooth controller #10634

Merged
merged 3 commits into from
Jul 10, 2023
Merged

4.2: Update sdl libraries to work with latest xbox bluetooth controller #10634

merged 3 commits into from
Jul 10, 2023

Conversation

patrickelectric
Copy link
Member

No description provided.

Holden and others added 3 commits March 23, 2023 18:38
@patrickelectric
Update Windows SDL2 library
7f03225
@patrickelectric
Update mac sdl2
10ac8bf
@joaoantoniocardoso @patrickelectric
deploy: windows: Update to Redis17, add missing DLLs
d52d1fc 
In runtime, QGC needs:
 - `vcruntime140.dll`
 - `vcruntime140_1.dll`
 - `msvcp140.dll`
 - `msvcp140_1.dll`

The update is necessary because `vcruntime140_1.dll` is only
shipped after MSVC Redistributables version 17
@patrickelectric patrickelectric changed the title Update sdl libraries to work with latest xbox bluetooth controller 4.2: Update sdl libraries to work with latest xbox bluetooth controller Mar 23, 2023
@booo
Copy link
Collaborator

booo commented Apr 6, 2023

I don't think we should push new features to the old release. I would rather push for a new major release and add such changes there.

Can we add the libraries as submodules?

@patrickelectric
Copy link
Member Author

I don't think we should push new features to the old release. I would rather push for a new major release and add such changes there.

Can we add the libraries as submodules?

It's not a new feature, is more a bug fix, to support the latest joysticks.

Can we add the libraries as submodules?

I was unable to find one, if one exist, it should be applied over master first, since this a major change that may affect the stability of the current stable release.

@booo
Copy link
Collaborator

booo commented Apr 15, 2023

I don't think we should push new features to the old release. I would rather push for a new major release and add such changes there.
Can we add the libraries as submodules?

It's not a new feature, is more a bug fix, to support the latest joysticks.

I still think new device support is an added feature and not a bug fix. But if you like feel free to merge this. I have no strong opinion about it.

@booo
Copy link
Collaborator

booo commented Apr 15, 2023

Is this change in master present?

@patrickelectric
Copy link
Member Author

Yes, it's a cherry-pick from master.
This is not a feature, is a bug fix for 4.2, but it appears to not take effect. I should get a new xbox controller to validate that next month.

@patrickelectric patrickelectric marked this pull request as draft April 17, 2023 16:06
@patrickelectric patrickelectric marked this pull request as ready for review July 10, 2023 22:57
@patrickelectric
Copy link
Member Author

Validated by multiple users.

@patrickelectric patrickelectric merged commit f66df93 into mavlink:Stable_V4.2 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickelectric @booo @joaoantoniocardoso