FollowMe: Fix "Always" settings for streaming GCS position #8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it looks like GCS motion reports will only be sent to vehicles that are in the appropriate "Follow" mode even when the "Stream GCS Position" setting is "Always". I've confirmed that GCS motion reports (FOLLOW_TARGET mavlink messages) aren't received using 4.0.4, whereas they were in version 3.5.6, when in a non-follow mode.
This PR should fix the issue. I haven't been able to fully test it as I'm not set up to build on Android and don't have a GPS I can use on my development machine.