Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more QTime deprecated functions #8676

Merged
merged 5 commits into from Apr 28, 2020
Merged

Fix more QTime deprecated functions #8676

merged 5 commits into from Apr 28, 2020

Conversation

patrickelectric
Copy link
Member

  • This fix a bunch of warning messages related to QTime functions that will be deprecated

@patrickelectric
QGCCameraControl: Remove deprecated function of QTime
234e581 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
QGCCameraManager: Move from QTime to QElapsedTimer to avoid deprecate…
83e7a60 
…d functions

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Joystick: Move from QTime to QElapsedTimer to avoid deprecated functions
4f3ed6f 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Vehicle: Move from QTime to QElapsedTimer to avoid deprecated functions
13edc46 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
MockLink: Move from QTime to QElapsedTimer to avoid deprecated functions
b6945ec 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Copy link
Member Author

@DonLakeFlyer @dogmaphobic this removed a bunch of warning messages, this is also part of my plan to remove all warnings in QGC, probably it'll be finished in more 2 patchs after this one

@DonLakeFlyer
Copy link
Contributor

What is being deprecated and when?

@patrickelectric
Copy link
Member Author

https://code.woboq.org/qt5/qtbase/src/corelib/time/qdatetime.h.html#209

@patrickelectric
Copy link
Member Author 

/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:240:49: warning: ‘int QTime::elapsed() const’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]                      [30/315]
  240 |                 if(pInfo->lastHeartbeat.elapsed() > 5000) {                                                                                                                                                  
      |                                                 ^                                                                                                                                                            
In file included from /usr/include/qt/QtCore/QDateTime:1,                                                                                                                                                            
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,                                                                                                                             
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,                                                                                                                               
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,                                                                                                                                 
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:                                                                                                                        
/usr/include/qt/QtCore/qdatetime.h:230:54: note: declared here                                                                                                                                                       
  230 |     QT_DEPRECATED_X("Use QElapsedTimer instead") int elapsed() const;                                                                                                                                        
      |                                                      ^~~~~~~                                                                                                                                                 
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc: In member function ‘virtual void QGCCameraManager::_stepZoom(int)’:                                                                            
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:462:32: warning: ‘int QTime::elapsed() const’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]                              
  462 |     if(_lastZoomChange.elapsed() > 40) {                                                                                                                                                                     
      |                                ^                                                                                                                                                                             
In file included from /usr/include/qt/QtCore/QDateTime:1,                                                                                                                                                            
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,                                                                                                                             
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,                                                                                                                               
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,                                                                                                                                 
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:                                                                                                                        
/usr/include/qt/QtCore/qdatetime.h:230:54: note: declared here                                                                                                                                                       
  230 |     QT_DEPRECATED_X("Use QElapsedTimer instead") int elapsed() const;                                                                                                                                        
      |                                                      ^~~~~~~                                                                                                                                                 
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:463:31: warning: ‘void QTime::start()’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]                                     
  463 |         _lastZoomChange.start();                                                                                                                                                                             
      |                               ^                                                                                                                                                                              
In file included from /usr/include/qt/QtCore/QDateTime:1,                                                                                                                                                            
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,                                                                                                                             
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,                                                                                                                               
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,                                                                                                                                 
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:                                                                                                                        
/usr/include/qt/QtCore/qdatetime.h:228:55: note: declared here
  228 |     QT_DEPRECATED_X("Use QElapsedTimer instead") void start();
      |                                                       ^~~~~
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc: In member function ‘virtual void QGCCameraManager::_stepCamera(int)’:
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:498:34: warning: ‘int QTime::elapsed() const’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
  498 |     if(_lastCameraChange.elapsed() > 1000) {
      |                                  ^
In file included from /usr/include/qt/QtCore/QDateTime:1,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:
/usr/include/qt/QtCore/qdatetime.h:230:54: note: declared here
  230 |     QT_DEPRECATED_X("Use QElapsedTimer instead") int elapsed() const;
      |                                                      ^~~~~~~
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:499:33: warning: ‘void QTime::start()’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
  499 |         _lastCameraChange.start();
      |                                 ^
In file included from /usr/include/qt/QtCore/QDateTime:1,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:
/usr/include/qt/QtCore/qdatetime.h:228:55: note: declared here
  228 |     QT_DEPRECATED_X("Use QElapsedTimer instead") void start();
      |                                                       ^~~~~
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc: In member function ‘virtual void QGCCameraManager::_stepStream(int)’:
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:512:34: warning: ‘int QTime::elapsed() const’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
  512 |     if(_lastCameraChange.elapsed() > 1000) {
      |                                  ^
In file included from /usr/include/qt/QtCore/QDateTime:1,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:
/usr/include/qt/QtCore/qdatetime.h:230:54: note: declared here
  230 |     QT_DEPRECATED_X("Use QElapsedTimer instead") int elapsed() const;
      |                                                      ^~~~~~~
/home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:513:33: warning: ‘void QTime::start()’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
  513 |         _lastCameraChange.start();
      |                                 ^
In file included from /usr/include/qt/QtCore/QDateTime:1,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkInterface.h:13,
                 from /home/patrick/git/blue/qgroundcontrol/src/comm/LinkManager.h:21,
                 from /home/patrick/git/blue/qgroundcontrol/src/QGCApplication.h:18,
                 from /home/patrick/git/blue/qgroundcontrol/src/Camera/QGCCameraManager.cc:8:
/usr/include/qt/QtCore/qdatetime.h:228:55: note: declared here
  228 |     QT_DEPRECATED_X("Use QElapsedTimer instead") void start();

@patrickelectric
Copy link
Member Author

#8352

@patrickelectric
Copy link
Member Author

Ping @DonLakeFlyer

1 similar comment
@patrickelectric
Copy link
Member Author

Ping @DonLakeFlyer

@DonLakeFlyer DonLakeFlyer merged commit c1dff16 into mavlink:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickelectric @DonLakeFlyer