Add a hill region to testable TerrainQueries. #9494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Terrain/TerrainQuery.cc
Outdated
| @@ -901,6 +910,19 @@ QList<double> UnitTestTerrainQuery::_requestCoordinateHeights(const QList<QGeoCo | |||
| long dx = regionSizeDeg/one_second_deg; | |||
| double fraction = 1.0 * x / dx; | |||
| result.append(std::round(UnitTestTerrainQuery::LinearSlopeRegion::minAMSLElevation + (fraction * UnitTestTerrainQuery::LinearSlopeRegion::totalElevationChange))); | |||
| } else if (hillRegion.contains(coordinate)) { | |||
| double arc_second_meters = (6371000. / 3600.) * (M_PI / 180); | |||
There was a problem hiding this comment.
What is 6371000 ? Please create an intermediary variable to describe this magic number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TerrainQueriestypically don't work in the test cycle, but a while back i have contributed special areas around Point Nemo where testing terrain-followingTransectStyleComplexItemsworks.Yet, we were missing a hill to verify transects are breaking on its top as expected and for LoS analysis. This only adds another useful region next to ones that are already there.