CameraTriggerIndicator: use a qml based icon instead: #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidsastresas
force-pushed
the
PR/Camera_icon_perf_issue
branch
from
c887d81
to
b27ceb5
Compare
There was performance issues when too many icons of this kind were displayed on the map, probably because of the old image based nature of the icon. This commit changes it to a qml rectangles based icon
Davidsastresas
force-pushed
the
PR/Camera_icon_perf_issue
branch
from
b27ceb5
to
cfeb4da
Compare
|
I saw the new "move to stable" label. Let me know if you need me to rebase this or whatever. Thanks! |
|
@Davidsastresas You can cherry pick to a pull to the Stable branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were performance issues when too many icons of this kind were displayed on the map, probably because of the old image based nature of the icon. This commit changes it to a qml rectangles based icon.
As discussed in issue #9501, the optimal way of addressing this would be by openGL shaders. This commit paints a camera icon based on qml rectangles instead, I am not familiarized with the openGL shaders approach right now, and I thought this could be a nice provisional fix.
The performance of QGC is not affected apparently anymore with this new icon. Some screenshots of the change:
Old icon:
New icon:
Let me know your thoughts, I will be happy to change the PR if needed. Thanks!