Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to the config file to disable the web server #35

Closed
Jokler opened this issue Feb 22, 2020 · 2 comments · Fixed by #75
Closed

Add an option to the config file to disable the web server #35

Jokler opened this issue Feb 22, 2020 · 2 comments · Fixed by #75
Assignees
@kilmanio
Labels
feature New feature or request good first issue Good for newcomers
Milestone
0.3.0

Comments

@Jokler
Copy link
Member

Jokler commented Feb 22, 2020

Is your feature request related to a problem? Please describe.
Not everyone running the bot is interested in supporting a web server with API too.

Describe the solution you'd like
It should be possible to set a feature flag to remove the web server components at build time.
@Jokler Jokler added the feature New feature or request label Feb 22, 2020
@Jokler
Copy link
Member Author

Jokler commented Mar 24, 2020

Making this an option in the cofiguration file would probably be simpler overall.

@Jokler Jokler changed the title Feature gate everything web server related Add an option to the config file to disable the web server Mar 24, 2020
@Jokler Jokler added this to the 0.3.0 milestone Oct 15, 2020
@Jokler Jokler added the good first issue Good for newcomers label Oct 15, 2020
@kilmanio
Copy link
Contributor

working on this

@kilmanio kilmanio mentioned this issue Oct 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilmanio kilmanio

Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Added an option to the config file to disable the web server kilmanio/pokebot
2 participants
@Jokler @kilmanio