Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cow instead #55

Closed
fkaa opened this issue Jul 12, 2020 · 4 comments
Closed

Use Cow instead #55

fkaa opened this issue Jul 12, 2020 · 4 comments
Assignees
@zealsprince
Labels
good first issue Good for newcomers

Comments

@fkaa
Copy link
Collaborator

fkaa commented Jul 12, 2020

pokebot/src/web_server.rs

Line 53 in 3575ac5

args.bot.quit(String::from("Stopping"));

@fkaa fkaa added the good first issue Good for newcomers label Jul 12, 2020
@Jokler Jokler assigned fkaa and unassigned Jokler Jul 12, 2020
@fkaa fkaa assigned zealsprince and unassigned fkaa Jul 12, 2020
@fkaa fkaa changed the title Use &str instead Use Cow instead Jul 12, 2020
@zealsprince
Copy link
Member

I don't get what you want from me. What is cow.

@Jokler
Copy link
Member

Jokler commented Jul 14, 2020

A Cow<'_, str> can be String or &str, whichever one is needed.

@zealsprince
Copy link
Member

Oh that's pretty neat. Didn't know about this and thought it was just some inside joke I missed :)

@Jokler
Copy link
Member

Jokler commented Aug 9, 2020

Closed because no one responded for 26 days.

@Jokler Jokler closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zealsprince zealsprince

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fkaa @zealsprince @Jokler