-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axis swap in affine_transform #12
Comments
Also cc:ing @jni |
Also we uncovered #13 while trying to clarify this issue, and clarify we did: the axes of the data array are inverted here: gputools/gputools/transforms/transformations.py Lines 75 to 77 in 0084689
presumably because OpenCL requires/expects (?) F-ordered data (or is it just that the kernel is implemented in this way?). However, imho the axis swapping should be invisible from the Python end, which would mean doing some transpositions of row/column reordering of the transformation matrix before handing it off to the GPU. @maweigert would you be ok with us adding a keyword option to do this, so that the matrix specification matches that in |
You were correct about the transform specification being different from |
Hi, thanks very much for these changes, very much appreciated. If still have to test whether rotations work as expected. If one could specify the |
Rotations also work as expected now. |
Should be in the latest pypi release now |
When testing affine_transform and comparing it to scipy.ndimage transform I get the impression
that gputools swaps dimensions 0 and 2. This should become clearer when looking towards the end of this notebook:
https://github.com/VolkerH/affine_transform_debugging/blob/master/Affine_transform.ipynb
The text was updated successfully, but these errors were encountered: