[src] Added ClientCreate and ClientClose hooks #2500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooks have been refactored from string to enum in dfc11d1 and this PR is unfortunately in conflict. |
|
Conflicts should be resolved. What is the opinion on this? |
|
Could you rebase and resolve the conflict directly in the commit ? |
|
🎉 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know these to some extend seem a bit weird, since there is no
clientscope, but i think they still have their place, for example to remove tools/doc clients when exitting the main client, which is especially useful when those clients are hidden.