Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing a specific window / area #37

Open
Ivshti opened this issue Jul 19, 2015 · 7 comments
Open

Sharing a specific window / area #37

Ivshti opened this issue Jul 19, 2015 · 7 comments

Comments

@Ivshti
Copy link

Ivshti commented Jul 19, 2015

Sharing a specific window or an area would be a nice capability - chromium has it as a functionality, as it uses it for chromecasting.

By initial research, I assume this happens by setting chromeMediaSource to "desktop" and chromeMediaSourceId to a value returned by chooseDesktopMedia - https://developer.chrome.com/extensions/desktopCapture.

@max-mapper
Copy link
Owner

technically that is not implemented in chromium but in chromes 'chrome app' libraries, I opened an issue requesting support for it in electron a while back electron/electron#1380

@TheSisb
Copy link

TheSisb commented Dec 15, 2015

Recently got merged into Electron (screen/window) electron/electron#2963

@max-mapper
Copy link
Owner

OH NICE FINALLY!!!

@max-mapper
Copy link
Owner

Docs for it are here: https://github.com/atom/electron/blob/9c861b9ad37a9c6335dde2e59d3005742fe75150/docs/api/desktop-capturer.md

This will let us implement a UI that asks the user what part of the screen they want to share. Currently we only share the entire screen. Being able to select only 1 screen would be pretty sweet :)

@max-mapper
Copy link
Owner

got it working in 9e93952

heres the UI I hacked up:

screen shot 2015-12-15 at 2 12 16 pm

because of the way it changes screen sharing, audio chat is currently not hooked up. I'll need to hook that up again with more code

feedback welcome!

@TheSisb
Copy link

TheSisb commented Dec 15, 2015

LGTM

@Raj123456788
Copy link

Can anyone please answer this question: electron/electron#4432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants