Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Practice missed words" option on results page #88

Closed
glazari opened this issue Aug 15, 2023 · 0 comments
Closed

Add "Practice missed words" option on results page #88

glazari opened this issue Aug 15, 2023 · 0 comments

Comments

@glazari
Copy link
Contributor

glazari commented Aug 15, 2023

On Monkeytype there is an option to practice the missed words from a test. I find this very useful for practicing.

Since there is an intention of making this feature compatible with monkeytype (as mentioned here #83) I think its a good candidate to add.

I can do the implementation if you like. I'll post here my idea in case you have comments or a better idea.

Implementation idea

My idea is to add a list of missed words to the Result,

struct Result {
    ...
    missed_words: Vec<String>
}

Then add a method to create new test from missed words, something like:

impl Test {
   from_missed_words(missed: Vec<String>) -> Test {...}

and maybe call it with the option p for practice on the main loop.

I will work on a PR with this idea, let me know what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants