Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help improve the logger performance #4

Closed
ralphjiang opened this issue Feb 21, 2017 · 1 comment
Closed

Help improve the logger performance #4

ralphjiang opened this issue Feb 21, 2017 · 1 comment
Assignees

Comments

@ralphjiang
Copy link

Could you add log level check first to improve performance?

String msg = r.getRule().getFullyQualifiedName() + "-{" + r.getRule().getExpression() + "}"; if(String.valueOf(o).equals("true")){ matchingRules.add(r.getRule()); log.info("matched: " + msg); }else{ log.info("unmatched: " + msg); }

@ralphjiang ralphjiang changed the title Help change the logger performance Help improve the logger performance Feb 21, 2017
@maxant maxant self-assigned this Feb 21, 2017
@maxant
Copy link
Owner

maxant commented Feb 21, 2017

@maxant maxant closed this as completed Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants