Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up uncss #46

Closed
bebraw opened this issue Jan 11, 2014 · 6 comments
Closed

Set up uncss #46

bebraw opened this issue Jan 11, 2014 · 6 comments
Labels
enhancement

Comments

@bebraw
Copy link
Contributor

bebraw commented Jan 11, 2014

See grunt-uncss. This should help in decreasing CSS size (ie. Bootstrap).
@XhmikosR
Copy link
Member

I can have a look at this, but it might be trickier due to angular and its components.
I need to double check if there are selectors injected via JS.

@bebraw
Copy link
Contributor Author

bebraw commented Mar 20, 2014

Blocked due to uncss/grunt-uncss#16.

@XhmikosR
Copy link
Member

I don't think this is worth atm. I mean OSSCDN loads bootstrap from bootstrapcdn. So there won't be any real gain from the rest IMO...

@bebraw
Copy link
Contributor Author

bebraw commented Mar 20, 2014

Ok, let's skip this.

@bebraw bebraw closed this as completed Mar 20, 2014
@XhmikosR
Copy link
Member

On the other hand, if we combined font awesome, bootstrap and our own style, the gain would be huge size-wise, but we'd miss the advantage of using those from a CDN...

@bebraw
Copy link
Contributor Author

bebraw commented Mar 20, 2014

I suppose it's fine. The site loads fairly quickly already.

It's good to be aware of these tools, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bebraw @XhmikosR