Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Replace unmaintained v4l crate with some better alternative #43

Closed
jirutka opened this issue Feb 6, 2022 · 6 comments

Comments

@jirutka
Copy link
Contributor

jirutka commented Feb 6, 2022

Please describe your feature request

Crate v4l from raymanfx/libv4l-rs is buggy (#43, #16) and seems to be unmaintained (see opened pull requests).

It fails to build on Alpine Linux (musl libc) due to wrong types, I had to patch it (which is a bit tricky for rust dependencies). I managed to build it on 64-bit architectures (and published Alpine package), but there are more problems on 32-bit architectures (armv7).

@jirutka jirutka changed the title [Feature request]: Replace unmaintained v4l crate with some maintained alternative [Feature request]: Replace unmaintained v4l crate with some better alternative Feb 6, 2022
@raymanfx
Copy link

Hi, libv4l-rs author here. I'd be happy to review patches to improve the armv7 and musl support - would you mind opening PRs so we can go through the changes together? Other issues can be sorted out as well I'm sure.

@MarijnS95
Copy link

On that note it does not seem like there are any alternatives to libv4l-rs at all, not to mention a "better" one: https://crates.io/search?q=v4l

Glad you're back by the way, @raymanfx!

@jirutka
Copy link
Contributor Author

jirutka commented Feb 17, 2022

I'd be happy to review patches to improve the armv7

There are many problems with types on 32-bit arches (not just armv7). I’m sorry, but I don’t care enough about 32-bit architectures to invest my time in it. Maybe @PureTryOut from postmartketOS will be interested.

@PureTryOut
Copy link

As postmarketOS we care about armv7 yes but so far we have no interest in this particular package. I must say it's the first time I heard of this package 😅

@raymanfx
Copy link

Quick heads-up: I am actively working on armv7 support in my crate as we speak and expect to fix these issues myself before long. The next branch [1] compiles fine for 32 bit triplets like armv7-unknown-linux-musleabihf right now and I expect to publish an update to crates.io soon.

@maximbaz
Copy link
Owner

Sounds like the issue is resolved, the library is proven to be maintained, issues are being worked on, and we don't know of any better alternative 😉 Thanks to everyone involved, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants