-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marker gene box is not closable by Esc #176
Comments
Oh... this is because the current object was not the dialog but the dataset
list. I'll need to focus on the dialog. thanks!
…On Fri, May 22, 2020 at 12:05 AM Nikolay Markov ***@***.***> wrote:
After the markers data is loaded via ajax, you build the table and then
explicitly remove the focus from the current object (
https://github.com/maximilianh/cellBrowser/blob/master/src/cbPyLib/cellbrowser/cbWeb/js/cellBrowser.js#L6192)
preventing the dialog box to close on Esc.
Is it intended, why?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#176>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACL4TNIZWUWSS6HSTYAKULRSWQT3ANCNFSM4NHG755Q>
.
|
I can send you a pull request with this line removed if you want |
Hm, do you remember if did we end up doing this? If yes, we can close the ticket... |
No, we haven't done this yet |
mxposed
added a commit
to mxposed/cellBrowser
that referenced
this issue
Jun 20, 2021
maximilianh
added a commit
that referenced
this issue
Jun 23, 2021
Do not remove focus after showing markers table, fixes #176
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the markers data is loaded via ajax, you build the table and then explicitly remove the focus from the current object (https://github.com/maximilianh/cellBrowser/blob/master/src/cbPyLib/cellbrowser/cbWeb/js/cellBrowser.js#L6192) preventing the dialog box to close on Esc.
Is it intended, why?
The text was updated successfully, but these errors were encountered: