Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pct of category in meta histogram #205

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

mxposed
Copy link
Contributor

@mxposed mxposed commented Dec 30, 2020

When you hover on a meta field with selection, it shows percentage of a given category that is selected after each category.

For instance:
Screen Shot 2020-12-29 at 18 25 27

So that you know not only how the selected cells distribute over this field, but also which proportion of those categories are covered

@maximilianh
Copy link
Owner

This makes a lot of sense.

Is it obvious to the user what "it" means here? Maybe we could spell out the meaning? Hmmm....

@mxposed mxposed changed the base branch from master to develop January 4, 2021 17:01
@mxposed
Copy link
Contributor Author

mxposed commented Jan 4, 2021

Change the PR to point to develop.

I couldn't come up with a better phrasing, but I agree, it sounds strange right now. Do you have an idea how to spell it out? ”Of this category”?

@matthewspeir
Copy link
Collaborator

matthewspeir commented Jan 5, 2021 via email

@mxposed
Copy link
Contributor Author

mxposed commented Jan 5, 2021

Yes, you're right, in the image above it says that 78% of selected cells have the value “Cortex”, and those 78% constitute 37.7% of all cells with the value “Cortex”.

An example: imagine a dataset with a rare cell type that comes only from 1 sample. Selecting all cells from that sample will show you the proportion of cell types in that sample. But with this second number, you can see that this rare cell type is found only in this sample.

During our exploration of datasets with cellbrowser, I found that I want to see the second value in the interface too, and

@maximilianh
Copy link
Owner

maximilianh commented Jan 6, 2021 via email

@mxposed
Copy link
Contributor Author

mxposed commented Jan 7, 2021

It's very clear, I like it and committed the change

@maximilianh
Copy link
Owner

Great! Thanks!

@maximilianh maximilianh merged commit 858117c into maximilianh:develop Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants