Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to locate 2.1.3 version #51

Closed
ubarua123 opened this issue Mar 12, 2021 · 4 comments
Closed

Unable to locate 2.1.3 version #51

ubarua123 opened this issue Mar 12, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@ubarua123
Copy link

Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom
       - https://jcenter.bintray.com/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom
       - https://repo.maven.apache.org/maven2/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom
       - https://jitpack.io/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom
       - https://dl.bintray.com/kotlin/kotlin-eap/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom
       - https://plugins.gradle.org/m2/com/maxkeppeler/bottomsheets/core/2.1.3/core-2.1.3.pom

allProjects {
         repositories {
             google()
             jcenter()
             mavenCentral()
             dependencies { apply from: "$rootProject.rootDir/version-groups.gradle" }
             maven { url "https://jitpack.io" } // add this line
             maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' }
             maven { url "https://plugins.gradle.org/m2/" }
         }
}

Any more repos I am missing out 😀

@ubarua123 ubarua123 added the bug Something isn't working label Mar 12, 2021
@bartez
Copy link

bartez commented Mar 13, 2021

Could you show your implementation in build.gradle for app? I found lib on maven central and link don't have bottomsheets.
Your url:

https://repo.maven.apache.org/maven2/com/maxkeppeler/**bottomsheets**/core/2.1.3/core-2.1.3.pom

Maven Central url:

https://repo1.maven.org/maven2/com/maxkeppeler/**sheets**/core/2.1.3/core-2.1.3.aar

@maxkeppeler
Copy link
Owner

The repo mavenCentral() is correct. (Is the repository in the buildscript or allprojects?)

The package name was previously changed from com.maxkeppeler.bottomsheets to com.maxkeppeler.sheets to reflect the functionality that a component can be displayed dynamically as a bottom-sheet or a dialog.

The dependencies look like this now:
implementation 'com.maxkeppeler.sheets:<module>:<latest-version>
Are your dependencies correct?

Overview of the dependencies:
https://search.maven.org/search?q=com.maxkeppeler.sheets

Browse the artifacts here:
https://repo1.maven.org/maven2/com/maxkeppeler/sheets/

Make sure to use the latest version.

I remember I had the same issue until I cleaned caches etc. Afterwards it pulled the library from the correct url.

@ubarua123
Copy link
Author

ubarua123 commented Mar 16, 2021

Thanks! Yes that was the issue. Didn't notice the package name change.

Another quick question: I want to the override the styles of the sheets. What is the parent style that I should extend in styles.xml? You have only specified the item attributes.

@maxkeppeler
Copy link
Owner

Great that it works now!

I use the parent style "Theme.MaterialComponents.DayNight.NoActionBar" in the sample. Either this style or a comparable style will do the job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants