Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.2 - add svg support #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

specious
Copy link

SVG images can be inlined too.

@specious
Copy link
Author

@maxogden, could you look at this?

@specious
Copy link
Author

specious commented Nov 1, 2016

I would love to see this package updated, but for now I've got a project depending directly on my fork.

@michaelschadhauser
Copy link

@maxogden: I need svg support as well - would be great if you could have a look at the pull request.

@specious
Copy link
Author

@maxogden, we hate to nag you, but this would probably only take a moment...

@specious
Copy link
Author

specious commented Nov 5, 2017

I'd like to add some clarification. <img> elements referencing *.svg files were already being inlined, however their content type was being listed as image/png which is the default.

@sujeetpillai
Copy link

This would be pretty useful for me as well. Please accept this pull-request.

@specious
Copy link
Author

Bump?

@specious
Copy link
Author

@maxogden, would you please take a quick look at this?

@specious
Copy link
Author

While this is waiting to be merged, this fork can be specified as a dependency with:

"dependencies": {
  "inline-images": "specious/inline-images#svg-support"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants