Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Review install guideline #7

Closed
glemaitre opened this issue Sep 15, 2018 · 3 comments
Closed

JOSS: Review install guideline #7

glemaitre opened this issue Sep 15, 2018 · 3 comments

Comments

@glemaitre
Copy link
Contributor

Couple of points to address:

  • I don't think that you depend on argparse since it is in the standard library.
  • You should as well mention that you support Python 3.5+
  • Is there a reason for the package to not work cross-platform. All packages installed with conda should work under MacOS and Windows.
  • I would remove the install_requires from the setup.py since the opencv package will be installed from pip even if it was installed with conda. You can instead create a requirements.txt for the PyPi folks.
  • The statement Place the downloaded ... is not correct for all environment and depending of the way that you installed the software.
@maxrousseau
Copy link
Owner

These issues have been resolved:

  • removed argparse
  • it has not been tested cross platform which is why i did not include it
  • i removed install_requires and replaced it with requirements.txt
  • fetcher.py function replaces the large file download
    can we close?

@arokem
Copy link

arokem commented Oct 22, 2018

@glemaitre : can this issue be closed?

@maxrousseau
Copy link
Owner

@glemaitre, @arokem: I believe this has been adressed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants