Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light_profile by clause not working #62

Closed
knjenga opened this issue Jan 29, 2024 · 2 comments · Fixed by #63
Closed

light_profile by clause not working #62

knjenga opened this issue Jan 29, 2024 · 2 comments · Fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@knjenga
Copy link

knjenga commented Jan 29, 2024

when using the light_profile function the by option only works when one variable is entred, when more than one variable is used the error listed bellow is displayed. Previously one could enter multiple rows and get a data frame that has predictions based on the desired variables.
 
fit <- lm(Sepal.Length ~ ., data = iris)
fl <- flashlight(model = fit, label = "iris", data = iris, y = "Sepal.Length")

light_profile(fl, v = "Petal.Length",
by = c("Species","Sepal.Width"),
type = 'predicted')

Error in nm %in% nms && !is.null(x[[nm]]) && !(x[[nm]] %in% colnames(x$data)) :
'length = 2' in coercion to 'logical(1)'

@mayer79
Copy link
Owner

mayer79 commented Jan 30, 2024

I will soon have a look at it, thanks.

@mayer79 mayer79 self-assigned this Feb 9, 2024
@mayer79 mayer79 added the bug Something isn't working label Feb 9, 2024
@mayer79
Copy link
Owner

mayer79 commented Feb 9, 2024

Fixed in #63

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants