Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--only-type (forks|sources) #20

Closed
ghost opened this issue Jan 23, 2019 · 6 comments
Closed

--only-type (forks|sources) #20

ghost opened this issue Jan 23, 2019 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 23, 2019

It would be nice to be able to ignore forks and only download source repos. Perhaps we could have a --only_type source option? Not sure if this is intuitive with Github's API or not.

@mazen160
Copy link
Owner

Great idea! Feel free to make a PR if you have time

@ghost
Copy link
Author

ghost commented Jan 24, 2019

Ok, thank you!

@mazen160
Copy link
Owner

Hi @teran-mckinney

I checked the PR for errors and issues. I prefered to do in-depth analysis on the update before merging it to not cause issues to users.

  1. The main function does not do input check for input regarding --prefix-mode. This is handled within the app in your copy.
    --prefix_mode x crashes the app.

  2. The directory mode is not working, since os.mkdir is not recursive. Current version have pass to Exception regarding os.mkdir, which sets it clean to console.


I will do the changes and fixes tonight.

Another change would be to call git without the module, since it's not actually useful, and is leading to a lot of errors.

All the best,
Mazin

@mazen160
Copy link
Owner

Hi @teran-mckinney

I merged and reviewed your PR regarding the --prefix-mode addition.

Regarding --only-type, I have found that the API supports it, there is a key called fork. The value is True|False. We can add this feature using this API.

Best Regards,
Mazin

@ghost
Copy link
Author

ghost commented Apr 1, 2019

Great, thank you! I will have to look into this later.

@mazen160
Copy link
Owner

This feature has been added #29. Now you can provide --exclude_forks, and you would be able to filter forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant