Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share on desktop #21

Closed
mazipan opened this issue May 30, 2021 · 5 comments
Closed

Share on desktop #21

mazipan opened this issue May 30, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@mazipan
Copy link
Owner

mazipan commented May 30, 2021

Currently we utilize the Web Share API which is not available on most of desktop browsers.

Need to add manual way to share URL when accessing from desktop device.

Maybe looking for some react-social-share, is it available?

@mazipan mazipan added the enhancement New feature or request label May 30, 2021
@kelilipan
Copy link
Contributor

My proposal is something like this

image

the idea is check if navigator.share is available if not then fallback using chakra popover

like I did in https://edufair-online-prototype-am3uxd9iz.vercel.app/kampus/EupZelxuvAOmyOeU7IUH

or do you have any suggestion 🤔

@mazipan
Copy link
Owner Author

mazipan commented Jun 19, 2021

For me, share to Twitter and WhatsApp is enough for starting.
Let me know if you can work on this issue.
Or can you guide me to the sample of code in how you implement this feature, maybe I can learn from it directly @svspicious

@kelilipan
Copy link
Contributor

I can work on this 😀

@mazipan
Copy link
Owner Author

mazipan commented Jun 19, 2021

Cool, let me know if you facing any issues when setting up the project on your local.
If you need a Supabase key for development, please DM me on Twitter https://twitter.com/Maz_Ipan, I have a different account for development purpose, you can use it for temporary, or you can just register by yourself, it's free

@kelilipan
Copy link
Contributor

Supabase pretty easy to setup actually.
And this app just needs one table (right? 🤔)

@mazipan mazipan closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants