Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilletShape.FLAT #21

Merged
merged 1 commit into from
Dec 3, 2018
Merged

FilletShape.FLAT #21

merged 1 commit into from
Dec 3, 2018

Conversation

emagdalenaC2i
Copy link
Collaborator

No description provided.

@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 3, 2018
Closed
14 tasks
@mbartlett21
Copy link
Owner

I'm not sure this will work very well with endFaces[].
You may need to update it to make sure it doesn't use the edge there

@emagdalenaC2i
Copy link
Collaborator Author

There a few issues with Mitter and Round options. But I will create a new PR to fix that

In this sample the feature of the left fails with Mitter
captura

In this example both mitter and round fail
captura2

@mbartlett21
Copy link
Owner

@emagdalenaC2i You can merge this if you want.
I'll leave it up to you.

@emagdalenaC2i
Copy link
Collaborator Author

@mbartlett21 Ok, you can merge ;-)

@emagdalenaC2i emagdalenaC2i merged commit 685c29b into master Dec 3, 2018
@emagdalenaC2i emagdalenaC2i deleted the emagdalenaC2i-patch-3 branch December 3, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbartlett21 mbartlett21 mbartlett21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emagdalenaC2i @mbartlett21