Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NameId to NameID? #22

Closed
fumieval opened this issue Oct 13, 2022 · 1 comment · Fixed by #28
Closed

Rename NameId to NameID? #22

fumieval opened this issue Oct 13, 2022 · 1 comment · Fixed by #28

Comments

@fumieval
Copy link
Contributor

I find it slightly confusing because it's called NameID in specification. Probably now is the best opportunity given that the subjectNameId field is inaccessible in the latest Hackage release.
@fumieval fumieval changed the title Rename NameId NameID? Rename NameId to NameID? Oct 13, 2022
@mbg
Copy link
Owner

mbg commented Oct 24, 2022

Sounds good to me.

fumieval added a commit to herp-inc/wai-saml2 that referenced this issue Oct 28, 2022
@fumieval
rename NameId to NameID (fixes mbg#22)
a340aad
fumieval added a commit to herp-inc/wai-saml2 that referenced this issue Oct 28, 2022
@fumieval
rename NameId to NameID (fixes mbg#22)
2a541c8
@mbg mbg linked a pull request Oct 29, 2022 that will close this issue
rename NameId to NameID (fixes #22) #28
Merged
4 tasks
@mbg mbg closed this as completed in #28 Oct 29, 2022
mbg pushed a commit that referenced this issue Oct 29, 2022
@fumieval
rename NameId to NameID (fixes #22) (#28)
17210e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename NameId to NameID (fixes #22) herp-inc/wai-saml2
2 participants
@mbg @fumieval