Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename NameId to NameID (fixes #22) #28

Merged
merged 1 commit into from
Oct 29, 2022
Merged

rename NameId to NameID (fixes #22) #28

merged 1 commit into from
Oct 29, 2022

Conversation

fumieval
Copy link
Contributor

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

@github-actions github-actions bot requested a review from mbg October 28, 2022 04:02
@mbg mbg linked an issue Oct 29, 2022 that may be closed by this pull request
Rename NameId to NameID? #22
Closed
mbg
mbg approved these changes Oct 29, 2022
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mbg mbg merged commit 17210e6 into mbg:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

Assignees

@fumieval fumieval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename NameId to NameID?
2 participants
@fumieval @mbg