Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The coverage doesn't work stand alone #5

Closed
shingara opened this issue Dec 11, 2012 · 7 comments
Closed

The coverage doesn't work stand alone #5

shingara opened this issue Dec 11, 2012 · 7 comments
Labels

Comments

@shingara
Copy link
Contributor

If we want the coverage we need start simplecov in our spec_helper like doing by example in dm-mapper ( https://github.com/datamapper/dm-mapper/blob/master/spec/spec_helper.rb#L6 )

It can be really great to put this information in devtools and insert it on spec_helper.rb by example.

@solnic
Copy link
Collaborator

solnic commented Dec 18, 2012

@shingara 👍

I actually wanted to do that but didn't find time 😄

@shingara
Copy link
Contributor Author

I try implement it. but I don't find a good way to do instead of adding a require needed in the spec_helper.rb.

Have you some idea how I can do to help ?

@mbj
Copy link
Owner

mbj commented Dec 18, 2012

IMHO we need to ship a default spec helper, like the Rakefile. Could look like this.

require 'devtools'
Devtools.spec_helper

# our project specific customizations here

We could ship the shared stuff from spec/support also in devtools.

EDIT: Markdown

@dkubb
Copy link
Collaborator

dkubb commented Apr 12, 2013

@shingara We now have the default spec helper in place. Do you want to give a try at generalizing this again?

I would think you could mostly use the same config we use in most DM2 related gems: https://github.com/dkubb/axiom/blob/master/spec/spec_helper.rb#L8-L23

The only thing is you'd probably want to read a config file so people can configure the filters and minimum coverage threshold.

@dkubb
Copy link
Collaborator

dkubb commented Apr 12, 2013

@shingara you may want to also check out #3 where there is some discussion on what a spec config file would look like. For the most part I wouldn't expect you to implement configurable unit/integration directories, we can add that later as a separate PR, but it's good for you to be aware of this if you decide to take it on.

@ghost ghost assigned solnic Jun 30, 2013
@solnic
Copy link
Collaborator

solnic commented Jun 30, 2013

I'm gonna add setting up SimpleCov. We already have devtools/spec_helper so it's gonna be easy.

@mbj
Copy link
Owner

mbj commented Oct 23, 2015

I'm closing this issue as its really old and the scope of this tool changed meanwhile.

@mbj mbj closed this as completed Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants