Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cagr argument in plot_transition_map() with x_axe #54

Closed
chilango74 opened this issue Mar 21, 2023 · 7 comments
Closed

Rename cagr argument in plot_transition_map() with x_axe #54

chilango74 opened this issue Mar 21, 2023 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chilango74
Copy link
Collaborator

Rename cagr argument in plot_transition_map() with more informative x_axe.
Default value should be "risk":
x_axe: str = 'risk'

Only two values are allowed: "cagr" and "risk".
@chilango74 chilango74 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 21, 2023
@mathii0402
Copy link
Contributor

Ok I can solve this.

@chilango74
Copy link
Collaborator Author

@mathii0402 ok. Thank you!

@mathii0402
Copy link
Contributor

Sorry I tried solving this and made a PR but the PR was closed. I don't know why

@chilango74
Copy link
Collaborator Author

@mathii0402 it looks like you have deleted it in your repository ...
image

@mathii0402
Copy link
Contributor

Ok I'll again fork and make a PR after making changes

@mathii0402
Copy link
Contributor

I had made a PR. You can check it out now!

@chilango74
Copy link
Collaborator Author

Thank you. Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chilango74 @mathii0402