Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Process data" button eternally showing "Loading" after upgrading to nfsen-ng v0.3 #104

Closed
urscale opened this issue Mar 7, 2024 · 4 comments

Comments

@urscale
Copy link

urscale commented Mar 7, 2024

First of all, thanks for this lovely piece of software, which has done a good job replacing nfsen for us!

Trying to upgrade to nfsen-ng v0.3, I've got everyhing working nicely, except for the "Process data" button in the "Flows" and
"Statistics" tabs, which never stops showing "Loading".

Briefly looked at the JavaScript involved, but couldn't easily figure out what might be going on.

Running on Debian 12 / PHP 8.2 / nginx 1.22.1 with php8.2-fpm

Let me know if there's anything I can do to help debug the issue.

@mbolli
Copy link
Owner

mbolli commented Mar 13, 2024

@urscale

Thanks for the report.

Please open the browser dev tools and set a break point on line 343 (inside setButtonLoading()).
Then reload the page. You should now see in the call stack why the button was set to loading.

Unfortunately in my installations I can't reproduce the issue.

@href
Copy link

href commented Mar 13, 2024

Urs asked me to take a look and I found the following:

setButtonLoading (nfsen-ng.js:343)
(anonymous) (nfsen-ng.js:855)
each (jquery.min.js:2)
each (jquery.min.js:2)
display_message (nfsen-ng.js:854)
(anonymous) (nfsen-ng.js:90)
c (jquery.min.js:2)
fireWith (jquery.min.js:2)
l (jquery.min.js:2)
(anonymous) (jquery.min.js:2)
load (async)
send (jquery.min.js:2)
ajax (jquery.min.js:2)
S.<computed> (jquery.min.js:2)
(anonymous) (nfsen-ng.js:80)
e (jquery.min.js:2)
t (jquery.min.js:2)
setTimeout (async)
(anonymous) (jquery.min.js:2)
c (jquery.min.js:2)
fireWith (jquery.min.js:2)
fire (jquery.min.js:2)
c (jquery.min.js:2)
fireWith (jquery.min.js:2)
ready (jquery.min.js:2)
B (jquery.min.js:2)

The setButtonLoading function is called exactly once and never again. It seems like it is done when the following message is loaded after the refresh:

Arc-2024-03-13-5gQ76ieK

At least that's the message processed in display_message, before setButtonLoading is called.

@mbolli mbolli closed this as completed in 5f7fb1e Mar 13, 2024
@mbolli
Copy link
Owner

mbolli commented Mar 13, 2024

thanks @href and @urscale for the additional information!

@urscale
Copy link
Author

urscale commented Mar 13, 2024

Yay, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants