Fix d3.xhr for local URIs. #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for local URI is based on jQuery's. Although Chrome has strict permissions, other browsers allow local URIs to be retrieved as long as the same-domain policy is respected e.g. Safari. We also check for a cross-domain request as req.status === 0 means failure in this case.
If the error flag is set, the response attribute [1] should be the empty string or null. So even if a request fails and the response has been partially loaded, this logic should still work. This check will fail for local requests where the response entity body is the empty string, but I don't think it's possible to detect this situation in current browser implementations. jQuery has the same issue, for example. [1]: http://www.w3.org/TR/XMLHttpRequest/#the-response-attribute
|
+1 on the concept, and the code looks like it'll do the job. |
|
Hurrah! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there's a simple way to support almost all local
file://requests (where req.status is always 0 in current browsers). The only case where this doesn't work is when the file does actually exist but is empty.I've tested the CORS use case in Chrome and Safari, and local xhr now works in Safari (it won't work in Chrome at the moment unless you relax the strict security settings).