improve error messaging in struct record/union serialization

RELEASE_NOTES.md

@@ -1,3 +1,6 @@
+### 3.3.0
+* Improve error messaging on struct record/union serialization.
+
 ### 3.2.0
 * Fix enum serialization for types that carry the DataContract attribute.
 

src/FsPickler.CSharp/Properties/AssemblyInfo.cs

@@ -1,13 +1,13 @@
-// <auto-generated/>
-using System.Reflection;
-
-[assembly: AssemblyProductAttribute("FsPickler")]
-[assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")]
-[assembly: AssemblyVersionAttribute("3.2.0")]
-[assembly: AssemblyFileVersionAttribute("3.2.0")]
-namespace System {
-    internal static class AssemblyVersionInformation {
-        internal const string Version = "3.2.0";
-        internal const string InformationalVersion = "3.2.0";
-    }
-}
+// <auto-generated/>
+using System.Reflection;
+
+[assembly: AssemblyProductAttribute("FsPickler")]
+[assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")]
+[assembly: AssemblyVersionAttribute("3.3.0")]
+[assembly: AssemblyFileVersionAttribute("3.3.0")]
+namespace System {
+    internal static class AssemblyVersionInformation {
+        internal const string Version = "3.3.0";
+        internal const string InformationalVersion = "3.3.0";
+    }
+}

src/FsPickler.Json/AssemblyInfo.fs

@@ -1,12 +1,12 @@
-namespace System
-open System.Reflection
-
-[<assembly: AssemblyProductAttribute("FsPickler")>]
-[<assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")>]
-[<assembly: AssemblyVersionAttribute("3.2.0")>]
-[<assembly: AssemblyFileVersionAttribute("3.2.0")>]
-do ()
-
-module internal AssemblyVersionInformation =
-    let [<Literal>] Version = "3.2.0"
-    let [<Literal>] InformationalVersion = "3.2.0"
+namespace System
+open System.Reflection
+
+[<assembly: AssemblyProductAttribute("FsPickler")>]
+[<assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")>]
+[<assembly: AssemblyVersionAttribute("3.3.0")>]
+[<assembly: AssemblyFileVersionAttribute("3.3.0")>]
+do ()
+
+module internal AssemblyVersionInformation =
+    let [<Literal>] Version = "3.3.0"
+    let [<Literal>] InformationalVersion = "3.3.0"

src/FsPickler/AssemblyInfo.fs

@@ -1,12 +1,12 @@
-namespace System
-open System.Reflection
-
-[<assembly: AssemblyProductAttribute("FsPickler")>]
-[<assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")>]
-[<assembly: AssemblyVersionAttribute("3.2.0")>]
-[<assembly: AssemblyFileVersionAttribute("3.2.0")>]
-do ()
-
-module internal AssemblyVersionInformation =
-    let [<Literal>] Version = "3.2.0"
-    let [<Literal>] InformationalVersion = "3.2.0"
+namespace System
+open System.Reflection
+
+[<assembly: AssemblyProductAttribute("FsPickler")>]
+[<assembly: AssemblyCopyrightAttribute("© Eirik Tsarpalis.")>]
+[<assembly: AssemblyVersionAttribute("3.3.0")>]
+[<assembly: AssemblyFileVersionAttribute("3.3.0")>]
+do ()
+
+module internal AssemblyVersionInformation =
+    let [<Literal>] Version = "3.3.0"
+    let [<Literal>] InformationalVersion = "3.3.0"

src/FsPickler/PicklerGeneration/FSharpTypeGen.fs

@@ -27,6 +27,10 @@ type internal FsUnionPickler =
         if not (isReflectionSerializable ty || PicklerPluginRegistry.IsDeclaredSerializable ty) then
             raise <| new NonSerializableTypeException(ty)
 
+        if ty.IsValueType then
+            // avoid emitting invalid IL for struct unions
+            raise <| new NonSerializableTypeException(ty, "Struct unions  not supported.")
+
         // Only cache by reference if typedef introduces custom or reference equality semantics
         let isCacheByRef = 
             containsAttr<CustomEqualityAttribute> ty 
@@ -252,6 +256,10 @@ type internal FsRecordPickler =
         if not (isReflectionSerializable ty || PicklerPluginRegistry.IsDeclaredSerializable ty) then
             raise <| new NonSerializableTypeException(ty)
 
+        if ty.IsValueType then
+            // avoid emitting invalid IL for struct records
+            raise <| new NonSerializableTypeException(ty, "Struct records not supported.")
+
         let fields = FSharpType.GetRecordFields(ty, allMembers)
         let ctor = FSharpValue.PreComputeRecordConstructorInfo(ty, allMembers)