Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination wrong if my theme specify padding for MuiIconButton #413

Closed
1981ats opened this issue Apr 3, 2019 · 3 comments
Closed

Pagination wrong if my theme specify padding for MuiIconButton #413

1981ats opened this issue Apr 3, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@1981ats
Copy link

1981ats commented Apr 3, 2019

Please excuse my bad English.
If i overrides padding for MuiIconButton root, because default is unnecessarily big for me, display pagination in table foother is wrong.

overrides: {
    MuiIconButton: {
      root: {
        padding: 2,
      }
    },
},

material-table-pagination-wrong
The problem is probably in the m-table-pagination.js line
<Typography variant="caption" style={{flex: 1, textAlign: 'center', lineHeight: '48px'}}>
at a fixed value of 48px, which corresponds to the default sizes in material ui theme, but if I change padding or other sizes, it will cause a problem.

@mbrn
Copy link
Owner

mbrn commented Apr 3, 2019

I will test this case asap and try to find a custom solution

@mbrn mbrn self-assigned this Apr 3, 2019
@mbrn mbrn added the bug Something isn't working label Apr 3, 2019
@1981ats
Copy link
Author

1981ats commented Apr 4, 2019

Great. Thank you very much.

@mbrn mbrn closed this as completed in b1623c2 Apr 11, 2019
@mbrn
Copy link
Owner

mbrn commented Apr 12, 2019

This is done with version 1.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants