Tests fail with realistic inputs

[misterikkit]

I tried to add some tests to some working filters, and the tests consistently fail. I was able to reduce it to a minimal config that reproduces the problem. The filters are matching specific "noreply" addresses, but these services often include someone's display name, e.g. From: "Michele Bertasi (Google Docs)" <comments-noreply@docs.google.com>

I assumed the best test would be one that has a real from header in the from field, but the rule is not matching in gmailctl test.

$ gmailctl version
0.10.6

My config

// Import the standard library
local lib = import 'gmailctl.libsonnet';

// Some useful variables on top
// TODO: Put your email here
local me = 'YOUR.EMAIL@gmail.com';
local toMe = { to: me };


// The actual configuration
{
  // Mandatory header
  version: 'v1alpha3',
  author: {
    name: 'YOUR NAME HERE',
    email: me,
  },

  rules: [
    {
      filter: {
        or: [
          { from: 'noreply+foo@example.com' },
          { from: 'noreply@foo.dev.example.com' },
        ],
      },
      actions: {
        labels: ['foo'],
      },
    },
  ],
  tests: [
    {
      name: 'test the test',
      messages: [
        { from: '"Person One" <noreply@foo.dev.example.com>' },
        { from: '"Person Two" <noreply+foo@example.com>' },
      ],
      actions: {
        labels: ['foo'],
      },
    },
  ],
}

Expected: gmailctl test should pass
Actual:

$ gmailctl --config . test
Test results: Failed: 1/1

Failed test "test the test":
multiple errors (2):
- message #0 is going to get unexpected actions: {}
  Note:
  - Message: {
      "from": "\"Person One\" \u003cnoreply@foo.dev.example.com\u003e"
    }
  - Actions:
    --- want
    +++ got
    @@ -1,5 +1 @@
    -{
    -  "labels": [
    -    "foo"
    -  ]
    -}
    +{}
- message #1 is going to get unexpected actions: {}
  Note:
  - Message: {
      "from": "\"Person Two\" \u003cnoreply+foo@example.com\u003e"
    }
  - Actions:
    --- want
    +++ got
    @@ -1,5 +1 @@
    -{
    -  "labels": [
    -    "foo"
    -  ]
    -}
    +{}

Error: 1/1 config tests failed

[mbrt]

Just out of curiosity, why not using the email only instead of the full name + email?

noreply@foo.dev.example.com instead of "Person One" <noreply@foo.dev.example.com>.

gmailctl doesn't parse the address and just uses a simple string comparison.

[github-actions]

This issue is stale because it has been open for 30 days without activity.
This will be closed in 7 days, unless you add the 'lifecycle/keep-alive' label or comment.