Add support for Snap build #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a snapcraft.yaml file to configure the snapcraft build.
mbrt
requested changes
May 4, 2021
"classic" confinement requires approval to be pushed to the snap store and it was possible (using a few hacks) to use strict confinement. List of "hacks": - use xdg-open to open the an editor outside of the snap container - use a wrapper around xdg-open to wait for a user input - make $TMPDIR point to $SNAP_USER_DATA to allow xdg-open to open the config file - use homeishome-launcher to make sure Go returns the right path when using usr.HomeDir
|
I just pushed an other commit to add the documentation to the README and use strict confinement. I tried to document |
mbrt
requested changes
May 13, 2021
hack/editor-wrapper.sh
Outdated
| @@ -0,0 +1,11 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Since this script is used only by snap, could you move it under the snap directory?
There was a problem hiding this comment.
My turn to apology for the delay 😄 . I moved it under snap/local. I couldn't move it under snap directly, it was raising this error:
The 'snap' directory is meant specifically for snapcraft, but it contains the following non-snapcraft-related paths, which is unsupported and will cause unexpected behavior:
- editor-wrapper.sh
If you must store these files within the 'snap' directory, move them to 'snap/local', which is ignored by snapcraft.
mbrt
approved these changes
May 21, 2021
|
Thank you @gjolly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
snapcraft.yamlfile to configure the snapcraft build.To build and install the snap (assuming
snapcraftutility is installed):The snap requires "classic" isolation because it's relying on config files in $HOME.