Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Option to enable/disable servers without removing them from conf #30

Closed
kDipak opened this issue Mar 26, 2020 · 4 comments
Closed

[Request] Option to enable/disable servers without removing them from conf #30

kDipak opened this issue Mar 26, 2020 · 4 comments

Comments

@kDipak
Copy link

kDipak commented Mar 26, 2020

Hello Matthieu :)

Is it possible to add the option to enable/disable servers. in the GUI ? current options is you have to use all of remove what you don't want to use.

I can disable it in the conf file by commenting them out, but when i open and change a setting in the GUI, it overwrites and removes the commented servers.
mbruel added a commit that referenced this issue Mar 26, 2020
@mbruel
Request #30: Option to enable/disable servers without removing them f…
7ebfe09 
…rom conf
@mbruel
Copy link
Owner

mbruel commented Mar 26, 2020

Hi Dipak,
I've added it.
Thanks for the donation ;)
Here is a win64 build.
I'll probably have some time during those confinement time, I may release the new version v4.5 in April.
Let me know if you find a bug, otherwise, please close the issue.
Cheers!

@kDipak
Copy link
Author

kDipak commented Mar 26, 2020

Thanks 👍 for adding it to the GUI.

the command line is ignoring it and using all servers :)

mbruel added a commit that referenced this issue Mar 27, 2020
@mbruel
Request #30: properly manage disabled servers (not only on GUI)
d9b45d7
@mbruel
Copy link
Owner

mbruel commented Mar 27, 2020

Indeed I went to fast and only focussed on the GUI...
Try this version, it should work for both cmd and GUI. (didn't test it but I'm quite confident)
Please close the issue if it's working as expected.
Cheers

mbruel added a commit that referenced this issue Mar 31, 2020
@mbruel
Request #30: Option to enable/disable servers without removing them f…
519e7bc 
…rom conf
mbruel added a commit that referenced this issue Mar 31, 2020
@mbruel
Request #30: properly manage disabled servers (not only on GUI)
0d19ce5
mbruel added a commit that referenced this issue Apr 1, 2020
@mbruel
Request #30: Option to enable/disable servers without removing them f…
d9367a6 
…rom conf

Former-commit-id: 519e7bc
mbruel added a commit that referenced this issue Apr 1, 2020
@mbruel
Request #30: properly manage disabled servers (not only on GUI)
9462f90 
Former-commit-id: 0d19ce5
mbruel added a commit that referenced this issue Apr 1, 2020
@mbruel
Request #30: Option to enable/disable servers without removing them f…
66fc364 
…rom conf

Former-commit-id: 519e7bc
Former-commit-id: c19e8d31a74ecf3e778b194e4de1a63c31da04b8
mbruel added a commit that referenced this issue Apr 1, 2020
@mbruel
Request #30: properly manage disabled servers (not only on GUI)
46aed47 
Former-commit-id: 0d19ce5
Former-commit-id: 41a30d9c0243e7d4f8b9701c38a500de7dce8137
@kDipak
Copy link
Author

kDipak commented Apr 1, 2020

Tested and working as intended in the cmdline version.

thank you.

@kDipak kDipak closed this as completed Apr 1, 2020
@firestarter7924 firestarter7924 mentioned this issue Feb 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kDipak @mbruel