Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --from commit option to be inclusive #87

Closed
sergey-ostapenko opened this issue Jun 1, 2018 · 2 comments
Closed

Make --from commit option to be inclusive #87

sergey-ostapenko opened this issue Jun 1, 2018 · 2 comments

Comments

@sergey-ostapenko
Copy link
Contributor

sergey-ostapenko commented Jun 1, 2018

Suggestion

Make --from option for command mbt build commit to include commit into the build.

Such behavior will be more git-like, plus we will be able to use same command build command when you have only one commit in your repository \ branch.

@buddhike
Copy link
Member

buddhike commented Jun 2, 2018

@sergey-ostapenko Thanks for the continued support with great suggestions. Is this working as expected?

@sergey-ostapenko
Copy link
Contributor Author

@BuddySpike I just found some counter arguments against the idea to be taken into account.

From the scripting perspective in CI \ CD process it could be more convenient to leave the functionality as is. Just because we almost always operating with merge base commit, or previously build commit. Both of them are telling us about build start point, but should not be included into the build.
Taking it into account, maybe we should change original proposal to be:

Allow two different options to setup start point of the build:

  1. --base for automation scenarios
  2. --from for human interaction, where from is inclusive. Because it is not convenient to do extra work to work with just one commit for which you already have sha1.

So if you think it is reasonable, we can re-open the issue, or alternatively we can just create new one that will better capture suggestion details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants