Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbt build branch doesn't honor dependencies #9

Closed
pznamensky opened this issue Jan 7, 2018 · 4 comments
Closed

mbt build branch doesn't honor dependencies #9

pznamensky opened this issue Jan 7, 2018 · 4 comments
Assignees
Labels

Comments

@pznamensky
Copy link

Hi,
We've noticed that when we're building project via:
mbt build branch master --in .
mbt builds modules one by one in alphabet order:

~ $ mbt build branch master --in . | grep INFO
INFO[0000] BUILD module-a in module-a for 4d7de1733c7b2b231e50ca197de714a6385916ed
INFO[0000] BUILD module-b in module-b for 6908e3e689b72ffd64070c281997c0c9d60271b5
INFO[0000] BUILD module-c in module-c for 68af707b99e9864f71b1f61be870307e48d0f1c3
INFO[0000] BUILD module-d in module-d for 024c073bf4e6efe31aed8281b48a998753d3214c

Nevertheless build diff --from <sha> --to <sha> --in . works as expected: modules building with honoring dependencies info:

~ $ mbt build diff --from <sha> --to <sha> --in . | grep INFO
INFO[0000] BUILD module-a in module-a for 4d7de1733c7b2b231e50ca197de714a6385916ed
INFO[0000] BUILD module-d in module-d for 024c073bf4e6efe31aed8281b48a998753d3214c
INFO[0000] BUILD module-c in module-c for 68af707b99e9864f71b1f61be870307e48d0f1c3
INFO[0000] BUILD module-b in module-b for 6908e3e689b72ffd64070c281997c0c9d60271b5
@buddhike buddhike self-assigned this Jan 8, 2018
@buddhike buddhike added the bug label Jan 8, 2018
@buddhike
Copy link
Member

buddhike commented Jan 8, 2018

Thanks for reporting this. I'm working on a fix for this.

@pznamensky
Copy link
Author

Thank you!

@buddhike
Copy link
Member

buddhike commented Jan 8, 2018

My pleasure. During very early days of mbt, it used to sort the modules by the path (for display purposes). Eventually, build command started using the same thing but, without removing the sort ;-). Thank you for reporting. New binaries should appear soon in bintray. Let me know how you go.

@pznamensky
Copy link
Author

Works fine for us.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants