Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploit fix, turning spawned pigs into zombie pigmans using lightning stike allows you gain XP #2918

Merged
merged 3 commits into from
Apr 28, 2016

Conversation

aromaa
Copy link
Contributor

@aromaa aromaa commented Apr 25, 2016

Some servers have option to spawn lightning stike if conditions are meet and abusing this to turn spawned pigs to zombie pigmans allowing crazy xp gains. This could also be abused by an abusive staff member.

@t00thpick1
Copy link
Member

Can you fix the spacing to match our formatting?

@aromaa
Copy link
Contributor Author

aromaa commented Apr 26, 2016

There you go! :)

@t00thpick1
Copy link
Member

I moreover meant tabs and spaces. Each indentation block should be 4 spaces. There should be no tab characters.

@aromaa
Copy link
Contributor Author

aromaa commented Apr 27, 2016

Oh I see, I thought they ware using spaces already

@t00thpick1 t00thpick1 merged commit 11aa126 into mcMMO-Dev:master Apr 28, 2016
@t00thpick1
Copy link
Member

Thanks

@Tslat
Copy link
Contributor

Tslat commented Apr 29, 2016

Tbh I feel like you'd be better off without this.

To get the conditions right to make this abuseable, you'd have to either:

  1. Have a way to manually spawn lightning
  2. Have abusive permissions/admins

If it's the former, then it should be up to the source of that functionality to support McMMO, not the other way around

If it's the latter, then it's already abuse that we shouldn't be catering to.
This would be akin to saying that all mobs spawned with commands or spawn eggs should be blocked from xp too, since they can be abused by admins

The way it is post-merge; natural lightning events no longer spawn pigmen that support xp. While a niche case, it's still a viable method.

EDIT: I guess I can accept that it only works on pigs that have the meta already (In what case does that ever happen anyway? lol)

t00thpick1 pushed a commit that referenced this pull request Jun 26, 2016
Merge pull request #2918 from isokissa3/master

His was better.

(cherry picked from commit 3ed0fdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants