Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatespeed #877

Closed
wants to merge 9 commits into from
Closed

Conversation

plugz
Copy link
Contributor

@plugz plugz commented Aug 10, 2016

This could be split in 2 pull requests:

Details in the commit messages.

The idea is: RGBMatrix innerSpeed differs from "normal" speed.
The "normal" speed is the "outer" speed.
The innerSpeed is the speed of each step.

Same for Chaser:
The innerSpeed is the speed for each step (in Common speed mode)
Other alternateSpeeds are available for Chaser,
these are the speeds of each individual step (in Per Step mode)

The alternateSpeed allows getting/setting these new Speeds.
This will allow the VCSpeedDial to change the speed steps of a Chaser.

The main goal of alternate speeds is: when changing the "normal" speed
of a chaser or rgbmatrix, the inner speed is not affected.
Otherwise the cuelist looks stopped while playing with a speeddial
Overridespeeds are ignored anyway
@plugz
Copy link
Contributor Author

plugz commented Aug 11, 2016

Screenshots of the speed dial properties & the function selection tool:

2 AlternateSpeed from a chaser are affected by this speed dial:
speed dial properties_002

When trying to add other functions or function alternate speeds in the speed dial, the currently selected alternate speeds are grayed (as is currently the case with functions)
select function_003

@mcallegari
Copy link
Owner

Ouch ! Perfect timing to conflict with what I am doing in the bpm branch 😭

By the way, how does the Function selection widget behave with Sequences ?

@plugz
Copy link
Contributor Author

plugz commented Aug 11, 2016

Ouch ! Perfect timing to conflict with what I am doing in the bpm branch 😭

Yes, I've seen you've been working on this too. Sorry about that 😄

For sequences, it simply writes "step 0", "step 1"... instead of "0.function0", "1.function1"....
Other than this, the behavior is the same.

I'll post a screenshot of a sequence in the function selection tool tonight if you want.

@plugz
Copy link
Contributor Author

plugz commented Aug 11, 2016

Here are screenshot with a sequence

speed dial properties_004

select function_005

Without this, when adding a sequence-container scene to a vcspeedial,
the contained sequence and it alternatespeeds
are not selectable anymore.
@janosvitok
Copy link
Contributor

If you need help merging alternatespeed and bpm, let me know.

Nitpicking: steps in UI should be numbered from 1, not 0, it's more "human" :)

@plugz
Copy link
Contributor Author

plugz commented Sep 1, 2016

Too many conflicts with the bpm stuff :(

@plugz plugz closed this Sep 1, 2016
@mcallegari
Copy link
Owner

What about my proposal of "speed override priority" ?

@plugz plugz mentioned this pull request May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB matrix fadein is broken when starting an RGB matrix from a VC slider
3 participants