Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFG_as923jp doesn't work properly #161

Closed
terrillmoore opened this issue Oct 28, 2018 · 0 comments
Closed

CFG_as923jp doesn't work properly #161

terrillmoore opened this issue Oct 28, 2018 · 0 comments
Assignees
@terrillmoore
Labels
bug
Projects
V2.3.0

Comments

@terrillmoore
Copy link
Member

A review of the docs led to the discovery that although we have CFG_as923jp in our BSPs and in CI, we don't act on it properly in config.h. Need to set CFG_as923and LMIC_COUNTRY_CODE appropriately if CFG_as932jp is set.
@terrillmoore terrillmoore self-assigned this Oct 28, 2018
@terrillmoore terrillmoore added this to To do in V2.3.0 via automation Oct 28, 2018
terrillmoore added a commit that referenced this issue Oct 28, 2018
@terrillmoore
Merge pull request #162 from mcci-catena/issue161
daaea1a 
Fix #161: support CFG_as923jp as shorthand
V2.3.0 automation moved this from To do to Done Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
No open projects
V2.3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore