Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom Golang version saved $GOROOT #8

Closed
Michionlion opened this issue Oct 17, 2018 · 5 comments
Closed

custom Golang version saved $GOROOT #8

Michionlion opened this issue Oct 17, 2018 · 5 comments

Comments

@Michionlion
Copy link
Collaborator

Michionlion commented Oct 17, 2018 •
edited
Loading

After running make setup in the colton/concurrent-testing branch, the go command no longer works, since it is looking for a $GOROOT at /home/mccurdyc/go-cover. There may be some saved environment variables in the binary? Not sure where else this could have been introduced.

This should be reproduced by just moving/renaming /home/mccurdyc/go-cover or otherwise sanitizing your environment, then running make setup && go version.
@Michionlion
Copy link
Collaborator Author

A completely clean install avoids this, but I'm not sure why...

@mccurdyc
Copy link
Owner

@Michionlion this is weird because we no longer use $GOROOT, instead, we are using $ which go

@mccurdyc
Copy link
Owner

ill try to reproduce with the steps you have provided above

@mccurdyc
Copy link
Owner

ahh but i bet $GOROOT is set in that binary when I build it. i will check

@mccurdyc
Copy link
Owner

mccurdyc commented Nov 1, 2018

This is no longer related to neighbor, but may be related to https://github.com/mccurdyc/go-cover

@mccurdyc mccurdyc closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Michionlion @mccurdyc