Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[adc] Add support for ADC module. #7

Merged
merged 1 commit into from
Apr 14, 2018
Merged

[adc] Add support for ADC module. #7

merged 1 commit into from
Apr 14, 2018

Conversation

BrendanSimon
Copy link
Contributor

Here's my first attempt at adding python bindings for the roboticscape ADC module.
It seems to work with my limited testing.

@BrendanSimon BrendanSimon mentioned this pull request Apr 14, 2018
Closed
@mcdeoliveira mcdeoliveira changed the base branch from master to devel April 14, 2018 21:46
mcdeoliveira
mcdeoliveira approved these changes Apr 14, 2018
View reviewed changes
Copy link
Owner

@mcdeoliveira mcdeoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great Brendan. I am merging them into devel for some testing before making into master. Thank you for your contribution!

@mcdeoliveira mcdeoliveira merged commit 4ec3637 into mcdeoliveira:devel Apr 14, 2018
@BrendanSimon BrendanSimon deleted the bjs/adc_bindings branch April 19, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdeoliveira mcdeoliveira mcdeoliveira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrendanSimon @mcdeoliveira