Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analog in? #5

Closed
nezra opened this issue Mar 17, 2018 · 5 comments
Closed

Analog in? #5

nezra opened this issue Mar 17, 2018 · 5 comments

Comments

@nezra
Copy link

nezra commented Mar 17, 2018

Specifically battery voltage and DC?

What is needed to add these

@BrendanSimon
Copy link
Contributor

Yes, I'm interested in ADC inputs too. e.g. to read distance sensors (optical, ultrasonic, etc).

What's the best way to read ADC inputs to use in conjunction with rcpy. Ideally rcpy would implement an ADC module, but since it's not present is there another solution in the interim?

@nezra
Copy link
Author

nezra commented Apr 11, 2018 via email

@BrendanSimon
Copy link
Contributor

The C libraries seem to be very comprehensive, and looking at the Python wrapper code it seems that it shouldn't be too difficult to add for the ADC module (and other missing modules too).

So I've taken the plunge (started a quick hacking investigation) to see if I can create the Python bindings to the low-level C functions.

@BrendanSimon
Copy link
Contributor

I've made some progress and my limited tests seem to suggest that it might work :)

You can find my fork/branch here:

https://github.com/BrendanSimon/rcpy/tree/bjs/adc_bindings

I've submitted a pull request here:

#7

@mcdeoliveira
Copy link
Owner

Thank you Brendan! I already merged with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants